New jack branch #39
Open
New jack branch #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/org/montclairrobotics/sprocket/control/ArcadeDriveInput.java # src/org/montclairrobotics/sprocket/drive/DriveModule.java # src/org/montclairrobotics/sprocket/drive/DriveTrainBuilder.java # src/org/montclairrobotics/sprocket/geometry/Polar.java # src/org/montclairrobotics/sprocket/geometry/Vector.java # src/org/montclairrobotics/sprocket/geometry/XY.java # src/org/montclairrobotics/sprocket/httpserver/Http.java
rafibaum
suggested changes
Jan 11, 2017
Contributor
rafibaum
left a comment
rafibaum
left a comment
There was a problem hiding this comment.
What's your rationale for getting rid of mappers and how do you plan on replacing their functionality? Also we do have to do code style now so once you're done I'm going to do a style check.
Collaborator
Author
|
1. Because there is a general solution which I think I have, and the
machinery to do it another way is as complicated as the rest of the
drivetrain. Maybe they have to stay, but I am at least going to try and
improve it.
2. I would agree to a code style, but I want to have input on writing it.
…On Wednesday, January 11, 2017, Rafi Baum ***@***.***> wrote:
***@***.**** requested changes on this pull request.
What's your rationale for getting rid of mappers and how do you plan on
replacing their functionality? Also we do have to do code style now so once
you're done I'm going to do a style check.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APpUfWZm-GBTFOBqoG5892D0kL3g2b3dks5rRVtBgaJpZM4LhGzc>
.
|
Contributor
|
If you're able to write the generic drive mapper and it works as well as any specific solution would then you're welcome to remove that functionality. Otherwise keep mappers in since we need to allow developers to express how they want to process joystick inputs into motor powers since that is a process that can differ wildly depending on a variety of factors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.