Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68b47c863f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| function assertNoUnresolvedLinkReferences() { | ||
| const unresolved = AGIJobManager.unlinked_binary.match(/__\$[a-fA-F0-9]{34}\$__/g) || []; |
There was a problem hiding this comment.
assertNoUnresolvedLinkReferences() inspects AGIJobManager.unlinked_binary, which is the pre-link artifact template and still contains __$...$__ placeholders even after deployer.link(...) succeeds. In practice this makes the migration throw on every run with MIGRATE_FROM_LEGACY_SNAPSHOT=1, blocking the legacy-snapshot deployment path on mainnet/forks despite successful library linking.
Useful? React with 👍 / 👎.
1 participant
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task