-
Notifications
You must be signed in to change notification settings - Fork 0
🎨 Palette: Add tooltips to social media badges #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🎨 Palette: Add tooltips to social media badges #8
Conversation
Adds title attributes to the ORCID, Mastodon, and Bluesky image links in the README.md file. This provides a helpful tooltip on hover, improving the user experience by giving context to the links.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughUpdated social and profile badge links in README.md by modifying image source domains and adding title attributes to anchor tags. These changes affect badge references to ORCID, Mastodon, and Bluesky profiles without altering any functional code logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Adds title attributes to the ORCID, Mastodon, and Bluesky image links in the README.md file. This provides a helpful tooltip on hover, improving the user experience by giving context to the links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [](https.orcid.org/0000-0002-5380-2029) | ||
| [](https.mastodon.scot/@james_mcmahon) | ||
| [](https.bsky.app/profile/strathview.uk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Broken URLs with malformed protocol separators.
All three social media badge links use https. instead of https://, which breaks both the badge image loading and the profile links. The shields.io service and destination profile URLs are inaccessible with this format.
Examples of the issue:
- Line 45:
https.img.shields.ioshould behttps://img.shields.io, andhttps.orcid.orgshould behttps://orcid.org - Line 46:
https.img.shields.ioandhttps.mastodon.scothave the same issue - Line 47:
https.img.shields.ioandhttps.bsky.apphave the same issue
The title attributes for tooltips are correctly implemented, but the links must be fixed immediately to restore functionality.
🔎 Proposed fix: Correct the protocol separators in all three badge links
-[](https.orcid.org/0000-0002-5380-2029)
+[](https://orcid.org/0000-0002-5380-2029)
-[](https.mastodon.scot/@james_mcmahon)
+[](https://mastodon.scot/@james_mcmahon)
-[](https.bsky.app/profile/strathview.uk)
+[](https://bsky.app/profile/strathview.uk)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| [](https.orcid.org/0000-0002-5380-2029) | |
| [](https.mastodon.scot/@james_mcmahon) | |
| [](https.bsky.app/profile/strathview.uk) | |
| [](https://orcid.org/0000-0002-5380-2029) | |
| [](https://mastodon.scot/@james_mcmahon) | |
| [](https://bsky.app/profile/strathview.uk) |
🤖 Prompt for AI Agents
In README.md around lines 45 to 47 the badge image and link URLs use malformed
protocol separators like "https." instead of "https://", which breaks image
loading and links; update each URL so img.shields.io and destination domains use
the correct "https://" scheme (e.g., change "https.img.shields.io" to
"https://img.shields.io" and "https.orcid.org" / "https.mastodon.scot" /
"https.bsky.app" to "https://orcid.org", "https://mastodon.scot",
"https://bsky.app" respectively) ensuring all badge image src and anchor href
values use valid https URLs.
This change adds title attributes to the social media badges in the README.md file. This provides a helpful tooltip on hover, improving the user experience by giving context to the links.
PR created automatically by Jules for task 1902214811801173025 started by @Moohan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.