Skip to content

Conversation

@nsabrams
Copy link
Collaborator

@nsabrams nsabrams commented Sep 19, 2025

This PR includes the following

  • Inclusion of Rubin and Roman filters by creating interpolations between UBV filters and those respective filters
  • Support for orbital motion in lightcurves generated and refactor of refine_binary_events to use lightcurve.py functions and be compatible with updated BAGLE
  • Inclusion of SDSS filter support via Galaxia
  • Support for multiple filters to be analyzed at once in refine_events() by using a filt_dict
    • NOTE in run.py this deprecates using photometric_system and filter in run.py, but it is still allowed when running refine_events() directly
    • Author: @SRemulla in PR Multiband refine events #68
  • Changes and tutorial for compatibility with synthpop as a replacement for galaxia+perform_pop_syn in some cases
  • Black hole splitting to allow user to choose binary black hole fraction
    • Fixed bugs in base function
    • Added capability to run this via run.py and slurm scripts
    • Author: @nsabrams
  • Bug Fixes and Misc
    • Make Einstein radius more precise by using astropy constants
    • Added some asserts to verify companions are matched between primary and companion .h5 files (just for debugging, there was no issue)
    • Updated test_synthetic.py multiplicity fraction and CO fraction. The code that produced these didn't change, but it appears that the numpy seed generation changed causing the fractions to shift by 1-2%.

Macy Huston and others added 30 commits June 27, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants