feature: remove support for multi-user systems #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It never relaly worked in practice, so this just adds complexity and noise at this stage. Now that our installer is fully compliant with the depracted shell installer, we have no need for the mutli-user support.
MrPointer
force-pushed
the
feature/remove-multi-user-support
branch
from
8aaba1f to
75c1c85
Compare
This is critical to get this PR passing CI, as our CI currently tries to apply dotfiles from `main`, but they're incompatible with our installer as they reference data that isn't there anymore. We need the CI to use the current branch it's running on for full compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes multi-user support, especially for brew installations.
It never really worked in practice, so this just adds complexity and noise at this stage. Now that our installer is fully compliant with the depracted shell installer, we have no need for the mutli-user support.
This PR also adds an important ability to apply dotfiles for a custom branch.
This is mainly used by CI to run E2E tests using the currently tested branch to ensure full compatibility.