Open
Conversation
Collaborator
|
@FJanssen-TNO I like this, and so far it looks good to me |
…lyzer pycml, which required the pass of the energy_system_options in the esdl_heat_model
…r to electrolyzer pycml
FJanssen-TNO
requested review from
KobusVanRooyen and
jimrojerTNO
as code owners
src/mesido/component_type_mixin.py
Outdated
| other_pipe = pipes_map[other_pipe_port] | ||
| if f"{other_pipe}.Q" not in alias_relation.canonical_variables: | ||
| alias_relation.add(f"{p}.Q", f"{sign_prefix}{other_pipe}.Q") | ||
| # if self.has_related_pipe(p): |
Collaborator
There was a problem hiding this comment.
Must this till be deleted?
src/mesido/gas_physics_mixin.py
Outdated
| self.__gas_storage_discharge_nominals[var_name] = self.variable_nominal( | ||
| f"{storage}.GasIn.Q" | ||
| ) | ||
| # self.__gas_storage_discharge_nominals[var_name] = self.variable_nominal( |
Collaborator
There was a problem hiding this comment.
Must this still be deleted?
src/mesido/gas_physics_mixin.py
Outdated
| var_name = f"{storage}.__Q_discharge" | ||
| self.__gas_storage_discharge_map[storage] = var_name | ||
| self.__gas_storage_discharge_var[var_name] = ca.MX.sym(var_name) | ||
| # self.__gas_storage_discharge_var[var_name] = ca.MX.sym(var_name) |
Collaborator
There was a problem hiding this comment.
Must this still be deleted?
| self.__heat_flow_direct_bounds[flow_dir_var] = (0.0, 0.0) | ||
| else: | ||
| self.__heat_flow_direct_bounds[flow_dir_var] = (0.0, 1.0) | ||
| # else: |
Collaborator
There was a problem hiding this comment.
Must this still be deleted?
src/mesido/heat_physics_mixin.py
Outdated
| flow_dir_var = f"{v}__flow_direct_var" | ||
|
|
||
| flow_dir_var = f"{v}.__flow_direct_var" | ||
| # |
Collaborator
There was a problem hiding this comment.
Must this still be deleted?
src/mesido/heat_physics_mixin.py
Outdated
| temp = max(parameters[f"{p}.temperature"], parameters[f"{p}.T_ground"]) | ||
| assert big_m > 0.0 | ||
|
|
||
| # big_m = big_m * 10 # kvr: This was needed to get the pipeline to pass |
Collaborator
There was a problem hiding this comment.
This was my temporary code which needs to be deleted. Sorry about this one
| def __init__(self, name, **modifiers): | ||
| super().__init__(name, **modifiers) | ||
|
|
||
| # away to create variables with a constant value over time is using the add_variable |
Collaborator
There was a problem hiding this comment.
Must this still be deleted?
|
|
||
| # away to create variables with a constant value over time is using the add_variable | ||
| # fixed, it does create variabeles for all timesteps | ||
| # self.add_variable(Variable, "_cost_test", min=0.0, fixed=True) |
Collaborator
There was a problem hiding this comment.
Must this still be deleted?
|
|
||
| self.add_variable(Variable, "dH") | ||
|
|
||
| print(modifiers["HeatIn"]["Heat"], modifiers["HeatOut"]["Heat"]) |
Collaborator
There was a problem hiding this comment.
Must this still be deleted?
Collaborator
|
@FJanssen-TNO review has been completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing discrete variables to be created in the pycml objects.
Implemented now for variables that are only linked to the asset itself and its energysystem properties.
Not implemented for variables that are dependent on other system variables, e.g. other assets or carrier options.