Conversation
…utch Gas electricity distribution case is uploaded
…as electricity case stud is added.
tests/test_gas_electricity.py
Outdated
| if ( | ||
| self.esdl_assets[self.esdl_asset_name_to_id_map[p]].attributes["state"] | ||
| == AssetStateEnum.ENABLED | ||
| ): |
There was a problem hiding this comment.
The state of the cable is in the parameters of the problem parameters[f"{p}.state"]. Also for all state checks you do below.
There was a problem hiding this comment.
updated. Check is done via : cable_state = self.parameters(0)[f"{p}.state"]
tests/test_gas_electricity.py
Outdated
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| def electricity_cable_classes(self, p): |
There was a problem hiding this comment.
Instead of "p" use "c" or "cable" for clarity.
tests/test_gas_electricity.py
Outdated
|
|
||
| base_folder = Path(example.__file__).resolve().parent.parent | ||
|
|
||
| class GasElectProblemExpensiveCable(GasElectProblem): |
There was a problem hiding this comment.
Move the updating/adapting of these classes to the model/gas_electricity_network/src/ directory.
There was a problem hiding this comment.
Updated. Adapted classes are moved to regarding models directory
tests/test_gas_electricity.py
Outdated
| ] | ||
| return cable_list | ||
|
|
||
| class GasElectProblemCheapCable(GasElectProblem): |
There was a problem hiding this comment.
You can inherit from the previous class and just change the costs of the cable classes. Makes it easier to track the differences between these classes.
There was a problem hiding this comment.
Currently both of the cheap and expensive cable classes inherit from the original cable class in in the gas_elect_workflow. But I can completly remove the expensive cable class and directly use the original cable class given in the gas_Elect_workflow
| def bounds(self): | ||
| bounds = super().bounds() | ||
| for c in self.energy_system_components.get("electricity_cable", []): | ||
| bounds.update({f"{c}__investment_cost": (0.0, np.inf)}) | ||
|
|
||
| return bounds |
There was a problem hiding this comment.
These bounds are updated here, but should be in asset sizing. and with dictionary. However, typically if no value had been provided, the investment costs bounds would have been nan or np.inf. So I'm wondering why this is added.
There was a problem hiding this comment.
You state it was removed but you did not state why it was here and if the required np.inf is indeed in place already?
src/mesido/asset_sizing_mixin.py
Outdated
| for ensemble_member in range(self.ensemble_size): | ||
| d = self.__electricity_cable_topo_max_current_resistance_parameters[ | ||
| ensemble_member | ||
| ] | ||
|
|
||
| d[f"{cable}.max_current"] = np.nan | ||
| d[f"{cable}.resistance"] = np.nan | ||
|
|
There was a problem hiding this comment.
Why do you make the parameters nan?
Check if this part in the pre (the loop over all cables) is really needed this extensively, or whether things can be simplified.
There was a problem hiding this comment.
@tolga-akan I see you have not replied to this one yet?
There was a problem hiding this comment.
Updated. This part is removed
There was a problem hiding this comment.
I did not say it should be removed. The question is why is it here. Is it needed here?
| esdl_file_name="EG_onshore_NL_gas_elec_case_study_drc_efvc_.esdl", | ||
| profile_reader=ProfileReaderFromFile, |
There was a problem hiding this comment.
If you have this code on github, then it should include an esdl and csv that are available on github as well.
There was a problem hiding this comment.
This is case is for the Dutch hydrogen / electricity grid case study. I have removed the esdl from mesido after we talk about that. I kept the run file there if anyone like to run using the regarding esdl in share point. I can completely remove the run file from mesido as well.
…topology_optimization. Style check is done.
3 participants
Uh oh!
There was an error while loading. Please reload this page.