👌🏻 Allow ServiceMatcher to be injected#234
Closed
yoan-myparcel wants to merge 1 commit intodevelopfrom
Closed
Conversation
M4tini
approved these changes
Mar 4, 2025
Member
Author
|
Closed in favor of #235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
ServiceMatcherdependency into theMyParcelComApiclass to improve service matching during API operations. The most important changes include adding theServiceMatcheras a private member, updating constructors and methods to handle this dependency, and refactoring thegetServicesmethod to utilize the newServiceMatcherinstance.Dependency Injection and Refactoring:
src/MyParcelComApi.php: AddedServiceMatcheras a private member to theMyParcelComApiclass.src/MyParcelComApi.php: Updated thecreateSingletonmethod to accept an optionalServiceMatcherparameter and pass it to the constructor.src/MyParcelComApi.php: Modified the constructor to accept an optionalServiceMatcherparameter and set it using a newsetServiceMatchermethod. [1] [2]src/MyParcelComApi.php: Refactored thegetServicesmethod to use the instance ofServiceMatcherinstead of creating a new one.src/MyParcelComApi.php: Added asetServiceMatchermethod to allow setting theServiceMatcherinstance.