♻️ Define StreamInterface return types and properly mock getBody#248
Merged
yoerriwalstra merged 1 commit intodevelopfrom Jul 16, 2025
Merged
♻️ Define StreamInterface return types and properly mock getBody#248yoerriwalstra merged 1 commit intodevelopfrom
StreamInterface return types and properly mock getBody#248yoerriwalstra merged 1 commit intodevelopfrom
Conversation
yoerriwalstra
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #246 the pipelines failed. To use the v2 version of
psr/http-messagewe have to define the return types (this is backwards compatible with v1) and we have to properly mockgetBodyin our tests.