Skip to content

Comments

Rejecting a return with optional message#1256

Merged
yoerriwalstra merged 6 commits intodevelopfrom
feature/MP-7673-rejecting-a-return-with-optional-message
Nov 28, 2025
Merged

Rejecting a return with optional message#1256
yoerriwalstra merged 6 commits intodevelopfrom
feature/MP-7673-rejecting-a-return-with-optional-message

Conversation

@daniel-myparcel
Copy link
Contributor

@daniel-myparcel daniel-myparcel commented Nov 26, 2025

What Changed

  1. ✨ Added message to rejection request and hook action
  2. ✨ Added rejection_message to Return

Jira Ticket

@yoerriwalstra yoerriwalstra self-requested a review November 27, 2025 09:09
@yoerriwalstra yoerriwalstra self-assigned this Nov 27, 2025
@yoan-myparcel
Copy link
Member

@yoerriwalstra @daniel-myparcel please hold on with the merge of this until I deploy staging 🙏🏻

@yoan-myparcel
Copy link
Member

@yoerriwalstra @daniel-myparcel I released to staging. This can be now reviewed and merged freely.

"properties": {
"message": {
"type": "string",
"description": "Message explaining the reason for rejection."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Message explaining the reason for rejection."
"description": "Message explaining the reason for rejection.",
"example": "My return reject message"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh mb mb 🫠

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now its done

@yoerriwalstra yoerriwalstra merged commit 5495e3e into develop Nov 28, 2025
1 check passed
@yoerriwalstra yoerriwalstra deleted the feature/MP-7673-rejecting-a-return-with-optional-message branch November 28, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants