Skip to content

Comments

✨ Add service.zone_code_to to Shipment specification#290

Merged
M4tini merged 2 commits intodevelopfrom
feature/MP-7853-add-zone_code_to-to-shipment-specification
Jan 27, 2026
Merged

✨ Add service.zone_code_to to Shipment specification#290
M4tini merged 2 commits intodevelopfrom
feature/MP-7853-add-zone_code_to-to-shipment-specification

Conversation

@yoerriwalstra
Copy link
Contributor

Comment on lines +56 to +60
"service": {
"required": [
"code"
]
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a little discussion with @M4tini about this on Slack. I asked why the service and service.code properties were only required for /get-multi-colli-service-rates and not also for /get-service-rates.

He explained that initially, the endpoint was built to support a request for rates for multiple services, which made it impossible for this field to be required. However, in practice, we only ever request a rate for a single service at a time through our API and we also assume that the first result in the response (which is an array) will contain the correct rate.

Therefore, it is not a problem and more accurately reflects how we retrieve dynamic service rates to make these properties required in the schema

@M4tini M4tini self-assigned this Jan 26, 2026
@yoerriwalstra yoerriwalstra requested a review from M4tini January 26, 2026 09:16
@M4tini M4tini merged commit e4cc9d9 into develop Jan 27, 2026
1 check passed
@M4tini M4tini deleted the feature/MP-7853-add-zone_code_to-to-shipment-specification branch January 27, 2026 20:11
@yoan-myparcel yoan-myparcel mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants