Skip to content

🐞 Fixed disappearing numeric field element keys #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoan-myparcel merged 2 commits into from
Sep 26, 2025
Merged

🐞 Fixed disappearing numeric field element keys #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe667e7
:beetle: Fixed disappearing numeric field element keys
yoan-myparcel Sep 26, 2025
eebced4
:fire: Simplified form validation - use generic messages
yoan-myparcel Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Form/Form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ public function validate(array $values): void
$validator = new Validator;
$validator->validate($values, $this->toJsonSchema(), Constraint::CHECK_MODE_TYPE_CAST);
if (!$validator->isValid()) {
$errorMessages = array_map(
fn ($error) => "[{$error['property']}] {$error['message']}",
$validator->getErrors(),
);
throw new FormValidationException("Form validation failed", $validator->getErrors());
}
}
Expand Down
12 changes: 5 additions & 7 deletions src/Form/FormElementCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,11 @@ public function getRequired(): array
public function getValues(): array
{
return array_filter(
Arr::collapse(
Arr::map(
(array) $this,
static fn (FormElement $formElement) => [
$formElement->name => $formElement->value(),
],
),
Arr::mapWithKeys(
(array) $this,
static fn (FormElement $formElement) => [
$formElement->name => $formElement->value(),
],
),
);
}
Expand Down
12 changes: 6 additions & 6 deletions tests/Form/FormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,12 @@ public function test_it_converts_to_json_schema(): void
public function test_it_gets_values(): void
{
$text = new Text(
name: 'name_1',
name: '1001',
label: 'Label 1',
value: 'Initial text',
);
$checkbox = new Checkbox(
name: 'name_2',
name: '1002',
label: 'Label 2',
value: true,
);
Expand Down Expand Up @@ -238,11 +238,11 @@ public function test_it_gets_values(): void
);

assertEquals([
'name_1' => 'Initial text',
'name_2' => true,
1001 => 'Initial text',
1002 => true,
'name_4' => [
'name_1' => 'Initial text',
'name_2' => true,
1001 => 'Initial text',
1002 => true,
],
], $form->getValues());
}
Expand Down