✨ Add showConfiguration constructor property to ShopSetupResponse#13
Merged
yoerriwalstra merged 2 commits intomasterfrom Sep 23, 2025
Conversation
yoerriwalstra
changed the title
yoerriwalstra
changed the title
followUpWithConfiguration constructor property to ShopSetupResponse
yoerriwalstra
force-pushed
the
feature/MP-7637-add-followUpWithConfiguration-to-ShopSetupResponse
branch
from
00011ad to
15fae2f
Compare
yoan-myparcel
changed the title
followUpWithConfiguration constructor property to ShopSetupResponseofferConfiguration constructor property to ShopSetupResponse
yoerriwalstra
force-pushed
the
feature/MP-7637-add-followUpWithConfiguration-to-ShopSetupResponse
branch
from
15fae2f to
18d07c2
Compare
yoan-myparcel
changed the title
offerConfiguration constructor property to ShopSetupResponseshowConfiguration constructor property to ShopSetupResponse
yoerriwalstra
force-pushed
the
feature/MP-7637-add-followUpWithConfiguration-to-ShopSetupResponse
branch
2 times, most recently
from
775d9cf to
b2d9b6a
Compare
yoan-myparcel
requested changes
Sep 23, 2025
| #[DataProvider('setupProvider')] | ||
| public function test_to_response( | ||
| ?string $authorizationUrl, | ||
| bool $followUpWithConfiguration, |
Member
There was a problem hiding this comment.
Suggested change
| bool $followUpWithConfiguration, | |
| bool $showConfiguration, |
| ): void { | ||
| assertSame( | ||
| $responseData, | ||
| new ShopSetupResponse($authorizationUrl, $followUpWithConfiguration) |
Member
There was a problem hiding this comment.
Suggested change
| new ShopSetupResponse($authorizationUrl, $followUpWithConfiguration) | |
| new ShopSetupResponse($authorizationUrl, $showConfiguration) |
Comment on lines
36
to
65
| return [ | ||
| [ | ||
| 'authorizationUrl' => null, | ||
| 'followUpWithConfiguration' => false, | ||
| 'responseData' => [ | ||
| 'data' => [ | ||
| 'show_configuration' => false, | ||
| ], | ||
| ], | ||
| ], | ||
| [ | ||
| 'authorizationUrl' => null, | ||
| 'followUpWithConfiguration' => true, | ||
| 'responseData' => [ | ||
| 'data' => [ | ||
| 'show_configuration' => true, | ||
| ], | ||
| ], | ||
| ], | ||
| [ | ||
| 'authorizationUrl' => 'http://localhost', | ||
| 'followUpWithConfiguration' => false, | ||
| 'responseData' => [ | ||
| 'data' => [ | ||
| 'show_configuration' => false, | ||
| 'authorization_url' => 'http://localhost', | ||
| ], | ||
| ], | ||
| ], | ||
| ]; |
Member
There was a problem hiding this comment.
Suggested change
| return [ | |
| [ | |
| 'authorizationUrl' => null, | |
| 'followUpWithConfiguration' => false, | |
| 'responseData' => [ | |
| 'data' => [ | |
| 'show_configuration' => false, | |
| ], | |
| ], | |
| ], | |
| [ | |
| 'authorizationUrl' => null, | |
| 'followUpWithConfiguration' => true, | |
| 'responseData' => [ | |
| 'data' => [ | |
| 'show_configuration' => true, | |
| ], | |
| ], | |
| ], | |
| [ | |
| 'authorizationUrl' => 'http://localhost', | |
| 'followUpWithConfiguration' => false, | |
| 'responseData' => [ | |
| 'data' => [ | |
| 'show_configuration' => false, | |
| 'authorization_url' => 'http://localhost', | |
| ], | |
| ], | |
| ], | |
| ]; | |
| return [ | |
| [ | |
| 'authorizationUrl' => null, | |
| 'showConfiguration' => false, | |
| 'responseData' => [ | |
| 'data' => [ | |
| 'show_configuration' => false, | |
| ], | |
| ], | |
| ], | |
| [ | |
| 'authorizationUrl' => null, | |
| 'showConfiguration' => true, | |
| 'responseData' => [ | |
| 'data' => [ | |
| 'show_configuration' => true, | |
| ], | |
| ], | |
| ], | |
| [ | |
| 'authorizationUrl' => 'http://localhost', | |
| 'showConfiguration' => false, | |
| 'responseData' => [ | |
| 'data' => [ | |
| 'show_configuration' => false, | |
| 'authorization_url' => 'http://localhost', | |
| ], | |
| ], | |
| ], | |
| ]; |
yoerriwalstra
force-pushed
the
feature/MP-7637-add-followUpWithConfiguration-to-ShopSetupResponse
branch
from
b2d9b6a to
3993d93
Compare
yoan-myparcel
requested changes
Sep 23, 2025
Co-authored-by: Yoan-Alexander Grigorov <46448148+yoan-myparcel@users.noreply.github.com>
yoan-myparcel
approved these changes
Sep 23, 2025
yoerriwalstra
deleted the
feature/MP-7637-add-followUpWithConfiguration-to-ShopSetupResponse
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
https://myparcelcombv.atlassian.net/browse/MP-7637