-
-
Notifications
You must be signed in to change notification settings - Fork 53
Add macOS sockaddr compatibility (sin_len/sin6_len fields) #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6360a22 to
7410138
Compare
|
^ @Mygod thanks for your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds macOS compatibility for sockaddr structures by including the sin_len and sin6_len length fields required by BSD-based systems. These fields must be the first members in sockaddr_in and sockaddr_in6 structures on BSD platforms.
Changes:
- Added conditional
sin_lenfield tosockaddr_instruct initialization - Added conditional
sin6_lenfield tosockaddr_in6struct initializations - Used
#[cfg(target_os = "macos")]to conditionally compile these fields
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/slipstream-ffi/src/runtime.rs | Added sin_len and sin6_len fields to sockaddr struct initializations in socket_addr_to_storage function |
| crates/slipstream-server/src/udp_fallback.rs | Added sin6_len field to sockaddr_in6 initialization in dummy_sockaddr_storage function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds
sin_lenandsin6_lenfields tosockaddr_inandsockaddr_in6structs for macOS compatibility. These fields are required on macOS but not on other platforms.Changes:
sin_len/sin6_lenfields inruntime.rsandudp_fallback.rsI test and build the changes in https://github.com/AliRezaBeigy/slipstream-rust-deploy
Addresses #14.