Skip to content

Conversation

@Mygod
Copy link
Owner

@Mygod Mygod commented Jan 24, 2026

Fixes #24.

@Mygod Mygod requested a review from Copilot January 24, 2026 01:44
@Mygod Mygod added the enhancement New feature or request label Jan 24, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a GitHub Actions workflow job to automatically build and upload slipstream binaries for macOS ARM64 and Linux x86_64 platforms, addressing issue #24 which requested automated binary builds as artifacts.

Changes:

  • Added build-binaries job to the CI workflow with a matrix strategy for macOS ARM64 and Linux x86_64 platforms
  • Configured platform-specific dependency installation for both Linux and macOS
  • Implemented binary packaging with SHA256 checksum generation
  • Set up artifact upload using GitHub Actions artifacts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +125 to +128
run: cargo build -p slipstream-client --release --target ${{ matrix.target }}

- name: Build slipstream-server
run: cargo build -p slipstream-server --release --target ${{ matrix.target }}
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build commands should include the --features openssl-vendored flag to create portable, self-contained binaries. Without this feature, the binaries will dynamically link against the system's OpenSSL library, which can cause compatibility issues when running on systems with different OpenSSL versions.

The openssl-vendored feature enables static linking of OpenSSL (via openssl-sys's vendored feature), ensuring the binaries work across different Linux distributions and macOS versions without requiring users to have specific OpenSSL versions installed.

This feature is already used in the rust-clippy-features job (line 82) and should be consistently applied to the release binaries as well.

Suggested change
run: cargo build -p slipstream-client --release --target ${{ matrix.target }}
- name: Build slipstream-server
run: cargo build -p slipstream-server --release --target ${{ matrix.target }}
run: cargo build -p slipstream-client --release --features openssl-vendored --target ${{ matrix.target }}
- name: Build slipstream-server
run: cargo build -p slipstream-server --release --features openssl-vendored --target ${{ matrix.target }}

Copilot uses AI. Check for mistakes.
@Mygod Mygod merged commit 47cf083 into main Jan 24, 2026
28 checks passed
@Mygod Mygod deleted the auto-binary branch January 24, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github Actions push built binaries as artifacts

2 participants