Skip to content

fix metrics for api #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rushrs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix metrics for api #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c8081
[metrics] fix failling metrics server for api
rushrs Jan 26, 2026
d3de0ea
[metrics] fix failling metrics server for api
rushrs Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/mvr-api/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,17 @@ pub async fn run_server(

println!("🚀 Server started successfully on port {}", api_port);

let _handle = tokio::spawn(async move {
let _ = metrics.run().await;
});
// Start the metrics service - must keep the Service alive or it aborts
let _metrics_service = metrics.run().await?;

axum::serve(listener, app)
.with_graceful_shutdown(async move {
cancellation_token.cancelled().await;
})
.await?;

// _metrics_service is dropped here, cleaning up the metrics server

Ok(())
}

Expand Down
Loading