Add git checks to ci #24577
Add git checks to ci #24577
Conversation
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
.github/workflows/rust.yml
Outdated
| git-checks: | ||
| name: git-checks | ||
| runs-on: [ ubuntu-latest ] | ||
| steps: | ||
| - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # Pin v4.1.1 | ||
| with: | ||
| ref: ${{ github.event.inputs.sui_repo_ref || github.ref }} | ||
| - run: ./scripts/git-checks.sh |
There was a problem hiding this comment.
remove this job and just add the git-checks.sh call to the existing lint job as an additional step
There was a problem hiding this comment.
Just so that we're on the same page, I am slightly confused about which lint job you're referring to. You mean the license-check that runs cargo xlint?
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
.github/workflows/rust.yml
Outdated
| license-check: | ||
| name: license-check | ||
| lints: | ||
| name: lints-check |
There was a problem hiding this comment.
You can't change the name of this job without a bunch of github setting issues as well as forcing the whole company to rebase their PRs to force trigger ci running again so lets not change the job name for now :)
There was a problem hiding this comment.
oh, I did not know that. Interesting.
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
left a comment
bmwill
left a comment
There was a problem hiding this comment.
One more fix needed then we can land this
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
2 participants
Description
This PR adds a script to check for various issues (e.g., merge commits in PRs, insensitive folder names, etc).
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.