-
Notifications
You must be signed in to change notification settings - Fork 83
[seal] batched key server requests #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
looks like integration test is failing, i am doing some investigation as to what's causing it now. |
|
|
hayes-mysten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this overall seems worth while, but we probably want to add some test coverage for these changes
|
Duplicates is not an issue after #293 has been merged, since |
|
Correct, your PR is a solid approach. However, this should still be viable in terms of batching the rpc requests for object data. Previously we used getObject for each passed ID, now we take all the passed ID's and make use of getObjects |
|
Ah, yes. Then this still makes sense, but you don't need to use a Set to avoid duplicates. |
Description
Deduplicates the passed object of key server object ID's so they are only fetched one time, and then returns the preserved array including the fetched content.
Test plan
unit tests