fix(codegen): omit .js in imports of generated files#538
fix(codegen): omit .js in imports of generated files#538milankyncl wants to merge 1 commit intoMystenLabs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks for opening this PR. Unfortunately I think this issue is more complicated that it appears. Would you be able to provide a reproduction of the next.js setup you are using that surfaces this issue? The codegen package is used in several other SDKs in this repo, and the This explains why we need There is a new setting in typescript I think we could potentially add an option to the config for omitting extensions from the compiled code but I would recommend exploring if there is a simple fix to the config for you project that will handle the code as is, because the |
Description
Removal of
.jsextension in imports of generated files.Why I raised this PR
I'm using this library within a Next.js project with TypeScript, which uses a strict compiler configuration. Files generated by codegen are TypeScript-based (so do they have extension
.ts) but imports have.jsextension so after running the project complier raises following error:Test plan
By manually editing generated files and then running the project again.
AI Assistance Notice