Fix broken MythUIImage::GetFilename() method #1238
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MythUIImage::SetFilename() stores the given filename into m_imageProperties.m_filename. MythUIImage::GetFilename() was getting the filename from 'm_filename'. As a result, these almost never match. The GetFilename() method has been updated to retrieve the filename from the same place where SetFilename() stores it. In adddition, the 'm_filename' data member has been eliminated since there are no users of it anymore. Resolves: MythTV#1138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MythUIImage::SetFilename() stores the given filename into m_imageProperties.m_filename. MythUIImage::GetFilename() was getting the filename from 'm_filename'. As a result, it always returned an empty string. The GetFilename() method has been updated to retrieve the filename from the same place where SetFilename() stores it. In addition, the 'm_filename' data member has been eliminated since there are no users of it anymore.
Resolves: #1138
Checklist