Reduce PortChecker blocking time #1249
Draft
+180
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when islinkLocal is true. The only difference is that it may return earlier due to testedAll.
islinkLocal and isIPAddress will always be true in the loop, since the function would have returned false otherwise.
Contributor
|
Scott, |
This should have been a separate commit to begin with. Instead of having checkPort() modify the host parameter, call resolveLinkLocal() explicitly to modify it. This potentially modified parameter was only used after one call to checkPort(). The call to resolveLinkLocal() should immediately return without checking the port, using the cached scope or returning false, since the st_dbStarted case can only be entered by fallthrough and the previous case calls checkPort().
Contributor
Author
|
The new commit only effects link-local IPv6 addresses. I'll need to reorder the commits and separate the change fully from the PortChecker::checkPort(): Call resolveLinkLocal() commit before merging. Also, change doxygen comment for MythContext::Impl::checkPort(). |
Contributor
|
Scott, after week to daily usage this code looks good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first attempt was reverted due to decoder timeouts (see #1234).
I have made more granular changes for bisecting if there is an issue. I also increased the log levels to make it easier to notice the PortChecker log messages; these should be lowered back to their prior values before merging. I should also fix the indent levels before merging.
@gigem @warpme Could you test this to see if it also causes the decoder timeout issue?
Checklist