Skip to content

Metals profile fix #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtremmel merged 3 commits into from
Jul 15, 2025
Merged

Metals profile fix #22

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
654a054
force pynbody to load in metal data to avoid issue with server modes …
Jun 20, 2025
cfde21a
Merge branch 'main' into metals_profile_fix
Jul 15, 2025
b8bf906
Merge branch 'main' into metals_profile_fix
Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ def plot_ylabel(self):
return r"Mass Flux $(M_\odot yr^{-1})$"

def _get_profile(self, halo, maxrad):
halo.g['metals']
halo.s['metals']
halo.g['FeMassFrac']
halo.s['FeMassFrac']
halo.g['OxMassFrac']
halo.s['OxMassFrac']

delta = self.plot_xdelta()
nbins = int(maxrad / delta)
maxrad = delta * nbins
Expand Down Expand Up @@ -186,6 +193,12 @@ def _get_profile(self, halo, maxrad):
ox_pro_g = None
ox_pro_s = None

halo.g['metals']
halo.s['metals']
halo.g['FeMassFrac']
halo.s['FeMassFrac']
halo.g['OxMassFrac']
halo.s['OxMassFrac']
if len(halo.g)>10:
pro_g = pynbody.analysis.profile.Profile(halo.g, type='lin', ndim=3,
min=0, max=maxrad, nbins=nbins, weight='mass')
Expand Down Expand Up @@ -227,6 +240,13 @@ def _get_profile(self, halo, maxrad):
fe_pro = None
ox_pro = None

halo.g['metals']
halo.s['metals']
halo.g['FeMassFrac']
halo.s['FeMassFrac']
halo.g['OxMassFrac']
halo.s['OxMassFrac']

if len(halo)>10:
if 'massHot' in halo.loadable_keys():
twophase = pynbody.filt.HighPass('massHot', 0)
Expand Down