Optimize datapackage cache operations#30
Merged
N00byKing merged 1 commit intoN00byKing:mainfrom Oct 18, 2025
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datapkg_cache.get("games", Json::objectValue)is always going to be the same; however with a datapackage cache of a significant size, this repeatedly causes a lengthy copy operation for every single game in the multiworld. This results in a significantly long delay on startup in big asyncs with a wide variety of games, even when the datapackages all match. Splitting this operation up like this makes checking for outdated game datapackages significantly faster (near instant).parseDataPkg()early if there are still outdated games we haven't received datapackages for yet, all the work it does will just be overwritten later. Saving this operation until the end and only calling it once speeds up fetching new datapackages significantly, without changing functionality at all.