Added more DataTypes for DataStorage#34
Draft
Jarno458 wants to merge 5 commits intoN00byKing:mainfrom
Draft
Conversation
added 3 commits
January 14, 2026 20:31
N00byKing
reviewed
Jan 15, 2026
Archipelago.cpp
Outdated
| break; | ||
| case AP_DataType::Double: | ||
| case AP_DataType::Int64: | ||
| int_val = root[i]["value"].asInt64(); |
Owner
There was a problem hiding this comment.
int_val is 32bit, I dont see how this works?
Contributor
Author
There was a problem hiding this comment.
Thats why its still draft, i still got to test it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed an uint64, but it felt odd to just add uint64 and not also int64,
i guess it also feels kinda odd not to add
uintwhen we do haveint, but if someone needs an uint, i guess it will fit in uint64 just like floats fit in the double