Open
Conversation
Daivuk
commented
Nov 18, 2023
| @@ -20,6 +20,7 @@ | |||
|
|
|||
| #define AP_OFFLINE_SLOT 1404 | |||
| #define AP_OFFLINE_NAME "You" | |||
Contributor
Author
There was a problem hiding this comment.
Should have been John Doe :)
Owner
There was a problem hiding this comment.
This way, if there is a message and you construct for example, "target got item", you get " You got item" which i thought was funny :3
Owner
|
The background library already does exponential backoff, so it wont spam the server completely. Instead, I'd accept a PR for a callback on unsuccessful connection, with a retry count and connection status param. Then, if needed, use |
Contributor
Author
|
Ok will do a new set callback tomorrow On Nov 17, 2023, at 7:09 PM, Yussur Mustafa Oraji ***@***.***> wrote:
The background library already does exponential backoff, so it wont spam the server completely. Instead, I'd accept a PR for a callback on unsuccessful connection, with a retry count and connection status param. Then, if needed, use AP_Shutdown and restart everything.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
But this never happend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's pointless to keep retrying forever. The game is waiting for a success or failure callback and the failure never comes. I am showing a popup in game and give the chance to the user to change the address and retry again