Skip to content

Limit connection retries#8

Open
Daivuk wants to merge 1 commit intoN00byKing:mainfrom
Daivuk:limit_connection_retries
Open

Limit connection retries#8
Daivuk wants to merge 1 commit intoN00byKing:mainfrom
Daivuk:limit_connection_retries

Conversation

@Daivuk
Copy link
Contributor

@Daivuk Daivuk commented Nov 18, 2023

It's pointless to keep retrying forever. The game is waiting for a success or failure callback and the failure never comes. I am showing a popup in game and give the chance to the user to change the address and retry again

@@ -20,6 +20,7 @@

#define AP_OFFLINE_SLOT 1404
#define AP_OFFLINE_NAME "You"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been John Doe :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way, if there is a message and you construct for example, "target got item", you get " You got item" which i thought was funny :3

@N00byKing
Copy link
Owner

The background library already does exponential backoff, so it wont spam the server completely. Instead, I'd accept a PR for a callback on unsuccessful connection, with a retry count and connection status param. Then, if needed, use AP_Shutdown and restart everything.

@Daivuk
Copy link
Contributor Author

Daivuk commented Nov 18, 2023 via email

@Jarno458
Copy link
Contributor

Jarno458 commented Feb 9, 2025

Ok will do a new set callback tomorrow On Nov 17, 2023

But this never happend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants