-
Notifications
You must be signed in to change notification settings - Fork 167
Print version of DART when running 'filter' #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tyiop794
wants to merge
10
commits into
NCAR:main
Choose a base branch
from
tyiop794:747-dart-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I'm struggling to get the CI build checks to pass, which is strange because it builds on my machine fine. It looks like it's unable to find the file containing the function that prints the version? |
… compile doesn't error out
Member
|
Thanks @tyiop794! It might be a week or two before we look at this because there are several pull requests in the queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
DART prints the version (retrieved using 'git describe --dirty --tags') when it is run.
Fixes issue
fixes #747
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
I have run the filter program multiple times. However, the tags do not seem to have transferred over to my fork, so in my case DART only prints 'unknown'. I'm still not sure how I would transfer those tags over.
Checklist for merging
Checklist for release
Testing Datasets