Enable nonhydrostatic option for FV3 #75
Conversation
There was a problem hiding this comment.
Copilot reviewed 23 out of 26 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ta440, I see that I forgot to close the loop on adding your fv3 mods. I created a new PR and was hoping that you might have time to test it and make sure that you see the tilt? Also you should be able to modify rearth and omega via the user_nl_cam namelist and create a small earth scaling by setting them directly in the user_nl_cam file to rearth/20. (=318561) and omega * 20 (=1.45842e-3). After you verify that this works I'll add a fv3_small_earth_scale namelist variable that will modify the default rearth and omega by some real value (default 20.) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I pulled out the extraneous mods. All mods are now just enabling nonhydrostatic mode. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
removed
the
ready_for_ci
|
❌ CI Test Failed I have removed the Action Required:
|
These changes to enable nonhydrostatic mode were provided by Timothy Andrews. In addition to Timothy's changes I modified the fv3_arrays.F90 file to allow the user to update the namelist variables rearth and omega to mimic the fv3 small_earth_scaling functionality. For example to enable a 1/20th scaling add omega and rearth to the user_nl_cam namelist with values set to omega * 20 and rearth / 20.