Improvements for large file handling and video height inference#4
Open
datasone wants to merge 2 commits intoNESStudio:mainfrom
Open
Improvements for large file handling and video height inference#4datasone wants to merge 2 commits intoNESStudio:mainfrom
datasone wants to merge 2 commits intoNESStudio:mainfrom
Conversation
For some old movie remastered versions (e.g. 688P, 1040P), auto guess the video height from filename (fallback to 1080P if filename not match), changes templates to fill in title and content respectively.
The old way reading files (`fs.readFileSync`) is hard limited to 2GB by node.js runtime. This commit switchs to `fs.ReadStream` API for handling large files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.ReadStreamAPI, supporting files larger than 2GB.