CODE RUB: Controllers remove page size debug comments#175
Open
CODE RUB: Controllers remove page size debug comments#175
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors OData pagination configuration by removing DEBUG-based conditional compilation directives and centralizing page size settings. The changes move from inline PageSize attributes in controllers to a configuration-based approach using appsettings.json and EDM model configuration.
- Removes
#if DEBUGconditional compilation blocks from all controller methods - Centralizes page size configuration in
appsettings.jsonfor both Portal and Manage servers - Implements page size configuration at the EDM model level in
GetEdmModel()methods
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| LondonDataServices.IDecide.Portal.Server/appsettings.json | Adds OData PageSize configuration (50) |
| LondonDataServices.IDecide.Portal.Server/Program.cs | Reads page size from config and applies it to entity sets in EDM model; removes unused imports |
| LondonDataServices.IDecide.Portal.Server/Controllers/PatientsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Portal.Server/Controllers/DecisionsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Portal.Server/Controllers/DecisionTypesController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/appsettings.json | Adds OData PageSize configuration (50) |
| LondonDataServices.IDecide.Manage.Server/Program.cs | Reads page size from config and applies it to entity sets in EDM model; adds required imports |
| LondonDataServices.IDecide.Manage.Server/Controllers/PatientsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/DecisionsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/DecisionTypesController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/Consumers/ConsumersController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/ConsumerAdoptions/ConsumerAdoptionsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES AB#25794