Merged
Conversation
github-actions
bot
added
the
CODE RUB
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Playwright end-to-end tests to align with changes in the application's UI, specifically updating test selectors and adding support for Power of Attorney (POA) workflow testing.
Changes:
- Updated test selectors from role-based to test-id based selectors for more reliable test targeting
- Added new helper functions to support POA field population in tests
- Modified test expectations to match new application flow and URL patterns
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| searchbynhsnumber.spec.ts | Updated NHS number input selectors and added POA field population to tests |
| homepage.spec.ts | Changed button selector to use test-id and updated expected navigation URL |
| helper.ts | Added new helper functions for POA button click and field population |
| home.tsx | Added test-id attributes to Start buttons for test targeting |
| searchByNhsNumber.tsx | Added test-id attribute to Search button for test targeting |
dcunliffe
approved these changes
Jan 29, 2026
davidhayes03
deleted the
users/davidhayes03/code-rub-playwright-updates
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES AB#27411