Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates copy and text across the application to improve clarity and consistency, replacing abbreviated terms with full names and correcting various grammatical issues. The changes also include commenting out NHS Login-related tests and updating translation files.
Changes:
- Updated branding from "OneLondon Data Portal" to "London Secure Data Environment Opt-Out Portal"
- Replaced abbreviations (LDS, SDE, LAP) with full names and improved copy clarity
- Commented out NHS Login authentication tests
- Fixed grammatical issues and standardized punctuation (e.g., "&" to "and")
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| azure-pipelines.yml | Added environment variable for NHS Login private key |
| LondonDataServices.IDecide.Portal.Client/tests/homepageNhsLogin.spec.ts | Commented out all NHS Login authentication tests |
| LondonDataServices.IDecide.Portal.Client/tests/homepage.spec.ts | Updated test expectations to match new copy text |
| LondonDataServices.IDecide.Portal.Client/src/locales/en/translation.json | Updated all user-facing text with improved clarity and full names |
| LondonDataServices.IDecide.Portal.Client/src/helpers/recaptureLoad.ts | Added badge position parameter to reCAPTCHA script |
| LondonDataServices.IDecide.Portal.Client/src/components/layouts/header.tsx | Updated header service name to new branding |
| LondonDataServices.IDecide.Portal.Client/src/components/home/home.tsx | Consolidated privacy notice links into single URL |
| LondonDataServices.IDecide.Portal.Client/src/components/confirmNhsLoginDetails/confirmNhsLoginDetails.tsx | Changed name format from "Given, Surname" to "Given Surname" |
| LondonDataServices.IDecide.Portal.Client/index.html | Updated page title to match new branding |
| LondonDataServices.IDecide.Manage.Client/src/locales/en/translation.json | Applied similar copy improvements as Portal client |
LondonDataServices.IDecide.Portal.Client/src/locales/en/translation.json
Outdated
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Client/src/locales/en/translation.json
Outdated
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Client/src/locales/en/translation.json
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Client/tests/homepage.spec.ts
Outdated
Show resolved
Hide resolved
cjdutoit
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including Tests
Closes AB#27500