Skip to content

Comments

CODE RUB: Copy Changes#191

Merged
davidhayes03 merged 8 commits intomainfrom
users/davidhayes03/code-rub-copy-changes
Feb 4, 2026
Merged

CODE RUB: Copy Changes#191
davidhayes03 merged 8 commits intomainfrom
users/davidhayes03/code-rub-copy-changes

Conversation

@davidhayes03
Copy link
Contributor

@davidhayes03 davidhayes03 commented Feb 4, 2026

Including Tests

Closes AB#27500

Copilot AI review requested due to automatic review settings February 4, 2026 12:58
@github-actions github-actions bot added the CODE RUB The code rub category is for small changes (not for bug fixes) label Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates copy and text across the application to improve clarity and consistency, replacing abbreviated terms with full names and correcting various grammatical issues. The changes also include commenting out NHS Login-related tests and updating translation files.

Changes:

  • Updated branding from "OneLondon Data Portal" to "London Secure Data Environment Opt-Out Portal"
  • Replaced abbreviations (LDS, SDE, LAP) with full names and improved copy clarity
  • Commented out NHS Login authentication tests
  • Fixed grammatical issues and standardized punctuation (e.g., "&" to "and")

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
azure-pipelines.yml Added environment variable for NHS Login private key
LondonDataServices.IDecide.Portal.Client/tests/homepageNhsLogin.spec.ts Commented out all NHS Login authentication tests
LondonDataServices.IDecide.Portal.Client/tests/homepage.spec.ts Updated test expectations to match new copy text
LondonDataServices.IDecide.Portal.Client/src/locales/en/translation.json Updated all user-facing text with improved clarity and full names
LondonDataServices.IDecide.Portal.Client/src/helpers/recaptureLoad.ts Added badge position parameter to reCAPTCHA script
LondonDataServices.IDecide.Portal.Client/src/components/layouts/header.tsx Updated header service name to new branding
LondonDataServices.IDecide.Portal.Client/src/components/home/home.tsx Consolidated privacy notice links into single URL
LondonDataServices.IDecide.Portal.Client/src/components/confirmNhsLoginDetails/confirmNhsLoginDetails.tsx Changed name format from "Given, Surname" to "Given Surname"
LondonDataServices.IDecide.Portal.Client/index.html Updated page title to match new branding
LondonDataServices.IDecide.Manage.Client/src/locales/en/translation.json Applied similar copy improvements as Portal client

Copilot AI review requested due to automatic review settings February 4, 2026 13:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

@davidhayes03 davidhayes03 merged commit 577425e into main Feb 4, 2026
5 checks passed
@davidhayes03 davidhayes03 deleted the users/davidhayes03/code-rub-copy-changes branch February 4, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CODE RUB The code rub category is for small changes (not for bug fixes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants