Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates portal copy and home page FAQs, plus adjusts auth token lifetime.
Changes:
- Extended token expiration from 5 to 30 minutes in server token generation.
- Added new FAQ section (“London Secure Data Environment”) and updated multiple user-facing strings.
- Updated header service name and wired a notification label to translations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| LondonDataServices.IDecide.Portal.Server/Program.cs | Increases generated token lifetime. |
| LondonDataServices.IDecide.Portal.Client/src/locales/en/translation.json | Adds/updates English copy including new FAQ section and labels. |
| LondonDataServices.IDecide.Portal.Client/src/components/layouts/header.tsx | Updates displayed service name in header. |
| LondonDataServices.IDecide.Portal.Client/src/components/home/home.tsx | Adds new expandable FAQ header/content entries. |
| LondonDataServices.IDecide.Portal.Client/src/components/confirmation/confirmationNhsLogin.tsx | Uses translation key for notification legend text. |
| LondonDataServices.IDecide.Portal.Client/src/components/confirmNhsLoginDetails/confirmNhsLoginDetails.tsx | Adds redirect when patient givenName is missing. |
Comments suppressed due to low confidence (1)
LondonDataServices.IDecide.Portal.Client/src/components/confirmNhsLoginDetails/confirmNhsLoginDetails.tsx:1
- Redirecting via window.location.href triggers a full page reload and bypasses SPA navigation (and also silently drops the user back to / with no explanation). Prefer using the app’s routing/navigation mechanism (e.g., react-router navigation) and consider showing an error state/message when required profile fields like givenName are missing.
import { useEffect, useState } from "react";
LondonDataServices.IDecide.Portal.Client/src/components/home/home.tsx
Outdated
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Client/src/locales/en/translation.json
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Client/src/components/layouts/header.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27500