Skip to content

CODE RUB: Copy Changes#193

Merged
davidhayes03 merged 2 commits intomainfrom
users/davidhayes03/code-rub-timout-login
Feb 9, 2026
Merged

CODE RUB: Copy Changes#193
davidhayes03 merged 2 commits intomainfrom
users/davidhayes03/code-rub-timout-login

Conversation

@davidhayes03
Copy link
Contributor

Fixes #27500

Copilot AI review requested due to automatic review settings February 9, 2026 11:51
@github-actions github-actions bot added the CODE RUB The code rub category is for small changes (not for bug fixes) label Feb 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates portal copy and home page FAQs, plus adjusts auth token lifetime.

Changes:

  • Extended token expiration from 5 to 30 minutes in server token generation.
  • Added new FAQ section (“London Secure Data Environment”) and updated multiple user-facing strings.
  • Updated header service name and wired a notification label to translations.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
LondonDataServices.IDecide.Portal.Server/Program.cs Increases generated token lifetime.
LondonDataServices.IDecide.Portal.Client/src/locales/en/translation.json Adds/updates English copy including new FAQ section and labels.
LondonDataServices.IDecide.Portal.Client/src/components/layouts/header.tsx Updates displayed service name in header.
LondonDataServices.IDecide.Portal.Client/src/components/home/home.tsx Adds new expandable FAQ header/content entries.
LondonDataServices.IDecide.Portal.Client/src/components/confirmation/confirmationNhsLogin.tsx Uses translation key for notification legend text.
LondonDataServices.IDecide.Portal.Client/src/components/confirmNhsLoginDetails/confirmNhsLoginDetails.tsx Adds redirect when patient givenName is missing.
Comments suppressed due to low confidence (1)

LondonDataServices.IDecide.Portal.Client/src/components/confirmNhsLoginDetails/confirmNhsLoginDetails.tsx:1

  • Redirecting via window.location.href triggers a full page reload and bypasses SPA navigation (and also silently drops the user back to / with no explanation). Prefer using the app’s routing/navigation mechanism (e.g., react-router navigation) and consider showing an error state/message when required profile fields like givenName are missing.
import { useEffect, useState } from "react";

@davidhayes03 davidhayes03 merged commit 4e1b886 into main Feb 9, 2026
5 checks passed
@davidhayes03 davidhayes03 deleted the users/davidhayes03/code-rub-timout-login branch February 9, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CODE RUB The code rub category is for small changes (not for bug fixes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments