Spelling of time series: timeseries -> time_series#114
Open
jesse-dugan wants to merge 2 commits intomainfrom
Open
Spelling of time series: timeseries -> time_series#114jesse-dugan wants to merge 2 commits intomainfrom
jesse-dugan wants to merge 2 commits intomainfrom
Conversation
modified functions, docs etc. to ensure that we remain consistent with infrasys spelling of time series as two words. Any time we used timeseries, I switched it to time_series. TimeSeries already implies two words so that stayed the same. Also found an import error in src\gdm\cli\reducer.py so I fixed that as well. We don't have tests for CLI I guess?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 111 111
Lines 3598 3598
=======================================
Hits 3452 3452
Misses 146 146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
please review @AadilLatif |
Collaborator
This looks great. I will make it part of the next release. I want to communicate upcoming changes and take some time, as it will break all downstream tools, |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Modified functions, docs etc. to ensure that we remain consistent with infrasys spelling of time series as two words.
Change Summary
Related issue number
Checklist