solve bug in evolven3fit

[evagroenendijk]

No description provided.

[felixhekhorn]

Can we please fix this deeper?

• remove q_fin from construct_eko_photon_cards - it is not used there: see here
• drop q_fin and q_points from the CLI

Can we please add a unit test? I'm surprised this has not come up earlier, because I suspect @jacoterh found the bug by just running the real life thing

[evagroenendijk]

Can we please fix this deeper?

• remove q_fin from construct_eko_photon_cards - it is not used there: see here
• drop q_fin and q_points from the CLI

Can we please add a unit test? I'm surprised this has not come up earlier, because I suspect @jacoterh found the bug by just running the real life thing

@felixhekhorn thanks for the comment, I completely agree! I was indeed looking at your first point, the second I’ll try later.

About the unit test, I tried to add something like it before, but did not add it eventually because it takes a long time even with few x points at LO (it has to produce a whole eko). Do we want to run that every time, or are you thinking of something else?

[scarlehoff]

I'm surprised this has not come up earlier,

Indeed.

Can we please add a unit test?

I think Andrea also tried and it was way too slow. We might want to have some tests that are run only before merging to master though, so that things show up much earlier.