Skip to content

Conversation

@sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Sep 23, 2025

matrix.h would not compile on XCode 16.4 and should not have built on other platforms. wxMatrix::ResizePreserve had undefined methods nrows() and ncols() used. Luckily the ResizePreserve function was not used elsewhere in the code base.

@sjanzou sjanzou self-assigned this Sep 23, 2025
@sjanzou sjanzou requested a review from brtietz September 23, 2025 09:16
@cpaulgilman
Copy link
Collaborator

@sjanzou Thanks for fixing. I noticed this when trying to build on Mac yesterday. The latest version of XCode is 26. Should we be using Version 16.4 to build SAM?

@sjanzou
Copy link
Collaborator Author

sjanzou commented Sep 23, 2025

@sjanzou Thanks for fixing. I noticed this when trying to build on Mac yesterday. The latest version of XCode is 26. Should we be using Version 16.4 to build SAM?

@cpaulgilman , my Mac has not finished updating to XCode 26, let me test and I will let you know.

Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for these changes. Happy to re-review for Xcode/Clang version upgrades in the future.

@sjanzou
Copy link
Collaborator Author

sjanzou commented Sep 24, 2025

@sjanzou Thanks for fixing. I noticed this when trying to build on Mac yesterday. The latest version of XCode is 26. Should we be using Version 16.4 to build SAM?

@cpaulgilman , my Mac has not finished updating to XCode 26, let me test and I will let you know.

@brtietz @cpaulgilman building and running with wxWidgets 3.2.8.1 on MacOS 26.0 with XCode 26.0.1 with Clang 17.1.1.17000319 with modification to configure and configure.in to remove deprecated -framework AGL per
(wxWidgets/wxWidgets@dd3f250)

image

@sjanzou sjanzou merged commit 717c4a6 into develop Sep 24, 2025
8 checks passed
@sjanzou sjanzou deleted the matrix_ResizePreserve branch September 24, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants