Skip to content

Comments

Moved all to be depricated code and files into an legacy folder; Comp…#69

Closed
sixym3 wants to merge 1 commit intoNSLS2:humblefrom
sixym3:chore/deprecate-legacy-code
Closed

Moved all to be depricated code and files into an legacy folder; Comp…#69
sixym3 wants to merge 1 commit intoNSLS2:humblefrom
sixym3:chore/deprecate-legacy-code

Conversation

@sixym3
Copy link

@sixym3 sixym3 commented Sep 16, 2025

@maffettone This PR is for a complete rewrite of the code base. One option is to merge into a WIP branch and then merge into humble at the end. Let me know which approach you prefer.

For now, this PR only removes the old code. I can open a follow-up PR to add the current implementation once you confirm the preferred workflow.

Copy link
Contributor

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no current BLs depending on this code base, and the paper versions are tagged, I'm fine working directly in the humble branch.

It seems you've come at this with a sludge hammer, where a knife would be more appropriate.

  • We should not trash demos. As discussed, and use them to clearly outline the architectural decisions without beamline or end effector specifics. I think Hello Moveit should remain and be expanded to have a Hello MTC, and/or a Hello MTC Orchestrator.
  • The custom srdfs and robot configs for the UR3e application are also not legacy unless you are replacing those as well and have tested them with a UR3e and the configs at PDF.
  • Containers should still be the primary product for portability and retain high value.
  • Tank you for modifying the readme to reflect changes. Please make sure there is a detailing to point to legacy contents in the main.

(Reviewing from a phone, apologies for terseness or formatting issues)

@sixym3 sixym3 closed this Sep 19, 2025
@sixym3 sixym3 deleted the chore/deprecate-legacy-code branch September 30, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants