Moved all to be depricated code and files into an legacy folder; Comp…#69
Closed
sixym3 wants to merge 1 commit intoNSLS2:humblefrom
Closed
Moved all to be depricated code and files into an legacy folder; Comp…#69sixym3 wants to merge 1 commit intoNSLS2:humblefrom
sixym3 wants to merge 1 commit intoNSLS2:humblefrom
Conversation
…lete rebuilding of code to use MoveIt
maffettone
suggested changes
Sep 17, 2025
Contributor
maffettone
left a comment
There was a problem hiding this comment.
Since there are no current BLs depending on this code base, and the paper versions are tagged, I'm fine working directly in the humble branch.
It seems you've come at this with a sludge hammer, where a knife would be more appropriate.
- We should not trash demos. As discussed, and use them to clearly outline the architectural decisions without beamline or end effector specifics. I think Hello Moveit should remain and be expanded to have a Hello MTC, and/or a Hello MTC Orchestrator.
- The custom srdfs and robot configs for the UR3e application are also not legacy unless you are replacing those as well and have tested them with a UR3e and the configs at PDF.
- Containers should still be the primary product for portability and retain high value.
- Tank you for modifying the readme to reflect changes. Please make sure there is a detailing to point to legacy contents in the main.
(Reviewing from a phone, apologies for terseness or formatting issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maffettone This PR is for a complete rewrite of the code base. One option is to merge into a WIP branch and then merge into humble at the end. Let me know which approach you prefer.
For now, this PR only removes the old code. I can open a follow-up PR to add the current implementation once you confirm the preferred workflow.