Open
Conversation
PI scanner is no longer used at FMX. It also uses old style PV changing to run the collection. If the scanner comes back its worth rewriting using bluesky
There was a problem hiding this comment.
Pull request overview
This pull request removes all references to the PI scanner hardware from the LSDC (Large Scale Data Collection) system at FMX beamline. The PI scanner is no longer in use and relied on old-style PV (Process Variable) changing methods for data collection.
Changes:
- Removed PI scanner configuration checks and conditional logic throughout the codebase
- Deleted two utility modules (Gen_Commands.py and Gen_Traj_Square.py) that were exclusively used for PI scanner trajectory generation
- Simplified raster scanning logic to remove PI-specific code paths including fine motor positioning
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gui/control_main.py | Removed scannerType configuration, fine motor (fineX/Y/Z) PV callbacks and position tracking, simplified raster cell indexing logic |
| daq_macros.py | Removed Gen_Commands and Gen_Traj_Square imports, deleted PI-specific raster functions (snakeRasterFine, snakeRasterNoTile, vectorZebraScanFine, gridRaster, etc.), simplified snakeRaster and vectorZebraScan functions, removed setScannerType configuration function |
| Gen_Traj_Square.py | Deleted entire file containing PI scanner trajectory generation code |
| Gen_Commands.py | Deleted entire file containing PI scanner command generation code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PI scanner is no longer used at FMX. It also uses old style PV changing to run the collection. If the scanner comes back its worth rewriting using bluesky