Gui updates fixes

[vshekar]

This pull request updates the control_main.py file to improve thread management, update Qt signal usage for combo boxes, and make several UI and logic adjustments for better stability and usability. The most significant changes include ensuring proper thread shutdown on close, switching to the recommended Qt signal for combo boxes, and disabling or hiding certain UI elements under specific conditions.

Thread Management and Stability Improvements:

• Ensured all camera and server check threads are properly stopped and waited upon during the window close event to prevent orphaned threads and improve application shutdown reliability (closeEvent).
• Removed redundant thread shutdown code from closeAll, centralizing thread cleanup in the close event handler.
• Fixed ServerCheckThread initialization by assigning it to self.serverCheckThread for consistent management and cleanup.

Qt ComboBox Signal Updates:

• Updated all QComboBox signal connections from the deprecated .activated[str] to .currentTextChanged for beamsizeComboBox, protoComboBox, and rasterEvalComboBox, aligning with best practices and ensuring correct callback behavior. [1] [2] [3]

UI and Logic Adjustments:

• Disabled the "Anneal" button when the beamline is "amx" to prevent unintended usage.
• Hid the "Center Loop" button in the sample alignment section, likely to simplify the UI or prevent its use.
• Removed the "priorityViewRadio" widget from the sample tab, possibly to streamline the available view options.

Minor Cleanups and Removals:

• Removed unused imports and constants for code cleanliness. [1] [2]
• Removed a redundant server call in takeRasterSnapshot, possibly to avoid duplicate actions.

[Copilot]

Pull request overview

This pull request updates the control_main.py file to improve thread management, update Qt signal usage for combo boxes, and make UI adjustments. The changes include ensuring proper thread shutdown on close, switching Qt signals for combo boxes, and disabling or hiding UI elements under specific conditions.

• Improved thread cleanup by centralizing camera and server check thread shutdown in the closeEvent handler
• Updated Qt signal connections for combo boxes from activated[str] to currentTextChanged
• Adjusted UI element visibility for specific beamlines (disabled Anneal button for AMX, hid Center Loop button, removed priorityViewRadio)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.