Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the cryostream hardware support from CS700 to CS1000 for the AMX and FMX beamlines, introducing user-facing controls for setting cryostream temperature and ramp rate.
Key Changes:
- Updated hardware device definitions to use CS1000 with new PV prefixes and suffixes matching the CS1000 interface
- Added backend functions
set_cryostream_tempandset_cryostream_ramp_rateto control cryostream parameters - Added UI controls in the user screen dialog (FMX only) for setting temperature and ramp rate
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| start_bs.py | Updated AMX and FMX beamline initialization to use cs1000 device with new PV prefixes |
| mxbluesky/devices/cryostream.py | Updated CryoStream class with new PV suffixes for CS1000 hardware and added ramp_rate component |
| config_params.py | Updated cryostreamTempPV dictionary with new CS1000 PV paths for AMX and FMX |
| daq_macros.py | Added set_cryostream_temp and set_cryostream_ramp_rate backend functions |
| daq_main_common.py | Registered new cryostream functions in server commands list |
| gui/dialog/user_screen.py | Added UI elements for temperature and ramp rate control with callbacks (FMX only) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for new cryostream hardware (the "CS1000" model) on the AMX and FMX beamlines, updating both backend device definitions and the user interface to allow users to set the cryostream temperature and ramp rate. It also removes outdated references to the old CS700 hardware and updates process variable (PV) names to match the new hardware. The most important changes are grouped below.
Cryostream Hardware and Device Updates:
start_bs.pyto use the newcs1000(CS1000) hardware and the correct PV prefix for both AMX and FMX beamlines, replacing the oldcs700(CS700) device. [1] [2]CryoStreamclass inmxbluesky/devices/cryostream.pyto use new PV suffixes for temperature readback, setpoint, ramp rate, and actuation, matching the CS1000 hardware interface.cryostreamTempPVdictionary inconfig_params.pyto use the new PVs for AMX and FMX, removing the old CS700 references.Backend Functionality:
set_cryostream_tempandset_cryostream_ramp_rateindaq_macros.pyto allow setting the cryostream temperature and ramp rate from the application.daq_main_common.py.User Interface Enhancements:
gui/dialog/user_screen.pyfor users to set the cryostream temperature and ramp rate, including input fields and buttons, and connected them to the backend via new callback methods. [1] [2] [3]