Conversation
We can't do `if zeroDegreeTiltImage`, because `zeroDegreeTiltImage` might be a numpy array which cannot be converted to a boolean. Instead, check the size, but only if it is not `None`. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This maximum was too large for whatever integer type Qt was using, and Qt could not set it correctly. We have to reduce it. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
It seems that somewhere unknown, the progress data is getting deleted, even though it is supposed to be just a shallow copy. This is causing crashes. If we make a deep copy, it avoids the problem. It's probably not that expensive to do, either, since the data object is empty. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This is necessary. It was deleted by accident. This also removes the installation of the `views.py` file which does not exist. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This helps the user see the live updates much more easily. You used to have to create a volume yourself to actually see the updates. So I think this will enable a lot more users to utilize these live update features more successfully. It also fixes some strange crash that would happen if the data was auto-updated but no visualization module had ever been created for that child data source. I spent two hours trying to determine the cause of the crash, but was not successful. However, this update is needed anyways, and it fixes the crash. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This is opposed to the numpy syntax, which is not inclusive of the last number. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This simply modifies the SID filter to only include the SIDs found within the txt file. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This allows the user to specify the path to the CSV log file when they are either creating a new dataset or just remaking the CSV file. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Aaron was clicking these buttons every time: +Z and -90 degrees. We can automate it so he does not need to do that. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This allows individual threaded operators to be executed externally, if specified so in the json file. It does so by using a wrapper around the transform to determine whether to invoke the operator in a normal way, or instead launch a subprocess where an external `tomviz-pipeline` executes it. This is a work in progress, so we might move around how things are done. We should use this same transform wrapper to automatically add `@apply_to_each_array`, unless a particular setting is present which says not to. I also had to change our usage of `np.bytes_` in the `tomviz-pipeline` code because the old behavior apparently broke. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Author
celiafish
previously approved these changes
Jan 29, 2026
Collaborator
|
Got the failure actions. Would you like to address that? @psavery |
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Author
|
Unfortunately, it looks like the recent release of pandas (version 3.0.0) broke this line in the xrf tomo library. The issue is that, starting in pandas 3.0.0, that I can put up a PR for fixing it on |
See: NSLS-II-SRX/xrf-tomo#10 Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Author
|
Okay, I pushed a commit to pin the pandas versions that I believe should work. See NSLS-II-SRX/xrf-tomo#10 for the fix on xrf-tomo. |
celiafish
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mostly includes various fixes requested by @aaron4444. He has been working from the branch on VDI that includes these, so he has been testing them. A few small new features include: