Fix up type hints #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds type hints to all methods, functions, and variables. Additionally, it adds an extra path for pyright to find NVDA source files, and adds documentation discussing this change in the README.
This PR adds docstrings to classes, methods, and functions.
* Removed type hint for _synthesizerRate (not needed here, since it is already defined globally) * Fixed type hint for getScript * Fixed ProsodyCommand type hints (should be BaseProsodyCommand)
Contributor
Author
|
I'm not sure why the PR diff here is french translations. The only diff here should be fd8f93f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge this as a merge commit not a squash merge to avoid future conflicts