Skip to content

Conversation

@A-Herfel
Copy link
Contributor

@A-Herfel A-Herfel commented Jul 8, 2025

Adds obstacle's ground truth data from Webots

Pre-PR Checklist:

Have you

  • Updated NUbook if necessary (add link to NUbook PR here)
  • Added/updated tests for your changes, including regression tests for bug fixes
  • Updated relevant module READMEs
  • Added/modified documentation directives in relevant code
  • Added a descriptive title and relevant labels to the PR

// Use ground truth data from Webots
for (const auto& gt_robot : robots_ground_truth->robots) {
// Skip our own robot using GlobalConfig player_id and team colour
if (!(gt_robot.player_number == static_cast<int32_t>(PLAYER_ID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if its better to filter this in the webots module. Not a big deal though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added as todo

@A-Herfel A-Herfel changed the title Herfel/ground truth obstacles Add ground truth for obstacles from Webots Jul 15, 2025
@A-Herfel A-Herfel added G-Localisation-Odometry Localisation and Odometry Group G-Behaviour Behaviour Group -New-Feature Something which we don't have or can't do labels Jul 15, 2025
@A-Herfel A-Herfel marked this pull request as ready for review July 15, 2025 12:16
@EthanBirdB EthanBirdB force-pushed the herfel/ground_truth_obstacles branch from 8e2a5ea to d66ad07 Compare October 19, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-New-Feature Something which we don't have or can't do G-Behaviour Behaviour Group G-Localisation-Odometry Localisation and Odometry Group

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants