RO-13: Planlegging #857
RO-13: Planlegging #857
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
jorgkv
force-pushed
the
feature/RO-13-turplaner
branch
from
c705c23 to
7e6f93c
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
2 similar comments
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
gruble
force-pushed
the
feature/RO-13-turplaner
branch
from
d8df8b1 to
b75d8f7
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
3 similar comments
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
gruble
force-pushed
the
feature/RO-13-turplaner
branch
from
50872a6 to
63052cc
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
3 similar comments
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
This PR implements "RO-13: Planlegging" - a new feature for importing, managing, and displaying GPS tracks (GPX and GeoJSON files) in the application. It adds a "Plans" tab where users can upload track files, view them on the map, and manage metadata like names and descriptions.
Key Changes
- Added new "Plans" tab with file import functionality supporting GPX and GeoJSON formats
- Integrated NVE Design System components for UI consistency
- Implemented GeoJSON storage service with IndexedDB persistence
- Enhanced map component to display multiple imported tracks with click interactions
- Added Source Sans Pro fonts to support the NVE Design System
Reviewed changes
Copilot reviewed 25 out of 38 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Updated TypeScript target to es2023 and module to esnext |
| src/main.ts | Added registration for NVE Design System icon library |
| src/global.scss | Added NVE Design System theme and Source Sans Pro font imports |
| src/assets/icon/*.svg | Added new SVG icons for plans feature (tour, input, delete, check, calendar, etc.) |
| src/assets/i18n/*.json | Added Norwegian and English translations for plans feature |
| src/app/pages/tabs/* | Updated tabs infrastructure to include new "Plans" tab |
| src/app/pages/plans/* | New pages for plan list and detail views with file upload functionality |
| src/app/core/services/geojson/* | New service for managing GeoJSON storage and metadata |
| src/app/modules/map/* | Enhanced map component to display imported tracks with metadata |
| package.json | Added dependencies for GeoJSON processing (@tmcw/togeojson, @Turf packages, nve-designsystem) |
src/app/pages/plans/plans.page.ts
Outdated
| IonMenuButton, | ||
| IonTitle, | ||
| TranslatePipe, | ||
| TranslatePipe, |
There was a problem hiding this comment.
The TranslatePipe is imported twice in the imports array. This is redundant and should be removed to keep the code clean.
| TranslatePipe, |
| [label]="'PLANS.COMMENT' | translate" | ||
| ></nve-textarea> | ||
| <div class="button-group"> | ||
| <nve-button variant="primary" type="submit" (click)="onSave()">Lagre</nve-button> |
There was a problem hiding this comment.
Dette med egen lagre-knapp per skjema er noe nytt i appen. Selv syns jeg ikke brukeropplevelsen er så god nå, med lagreknappen. Jeg prøvde feks å toggle en tur på bare med togglen, men glemte å trykke lagre fordi det er uvant og litt uvanlig sammenligna med appen ellers.
Tenker vi bør skrive om skjemaet til å lagre oppdateringene fortløpende så vi kan fjerne lagre-knappen. Eventuelt burde vi kanskje hatt to visninger av skjemaet, for å gjøre det tydeligere at "nå redigerer du". Feks at det var en helt statisk visning uten inputs / toggle, men med en rediger-knapp som åpner redigeringsvisning.
There was a problem hiding this comment.
vi har jo submit knapper noen steder (se bildet under). Å ikke ha en dedikert submit-knapp i et skjema gir lite mening med tanke på universell utforming. Uten en submit-knapp har vi ingen måte å informere brukeren om at noe faktisk er lagret. hvordan vil du informere skjermleser brukere at data var lagret? Nå som vi skal bruke designsystemet, må vi også ta vare på uu, syns jeg, og bruke best praksis.
Jeg merker vi ikke har submit knapper i underskjemaer (tror dette kan diskuteres), men når du faktisk vil sende et skjema klikker du på en knapp som lagrer det for deg. Akkurat som her. Det er kun et skjema i detaljside. Derfor submit knapp gir mening.
There was a problem hiding this comment.
vi har også fjernet switch fra skjemaet. switch er ment til å lagre endring med en gang du trykker på den uten noe ekstra lagre knapp. men vi trodde også at switch vi har er forvirrende og vi fjernet den. det kan også diskuteres senere
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
2 similar comments
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
gruble
force-pushed
the
feature/RO-13-turplaner
branch
from
1f31ea8 to
e299446
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
Co-authored-by: Øystein Myhre <71138449+gruble@users.noreply.github.com>
Co-authored-by: marcin <martin.joodd@gmail.com>
Co-authored-by: marcin <martin.joodd@gmail.com>
Co-authored-by: Øystein Myhre <71138449+gruble@users.noreply.github.com> Co-authored-by: Jørgen Loe Kvalberg <jolokv@nve.no>
gruble
force-pushed
the
feature/RO-13-turplaner
branch
from
e299446 to
e878b4a
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-water-056410803-857.westeurope.azurestaticapps.net |
Husk å rebase denne jevnlig så vi ikke får så mye konflikter til slutt.
Hvis du vil teste import av GPX-spor, kan du bruke f.eks. https://gpx.studio/ til å lage GPS-filer. https://geojson.io/ kan brukes til å lage GeoJSON-filer.
TODO