-
Notifications
You must be signed in to change notification settings - Fork 192
CUDA C++ Contriguting Guide #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Thank you for your contribution! This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI. @maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI. |
|
This pull request contains 1 unsigned commit(s):
All commits must be signed before this PR can be merged. Please sign your commits by following these steps: Option 1: SSH Key Signing (Recommended)
Option 2: GPG Key Signing
For more details, see GitHub's commit signature verification docs. This comment will be updated when you push new commits. |
657cefe to
a6af2d0
Compare
smish-nvidia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
|
||
| You can find the full solution [here](Solutions/no-magic-execution-space-changes.cpp). | ||
| </details> | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these nested code fences seem to be formatted incorrectly, but I'm not sure how to escape the backticks
| ach::where_am_I("CPU"); | ||
| ``` | ||
|
|
||
| You can find the full solution [here](Solutions/no-magic-execution-space-changes.cpp). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I tried to follow this link from the markdown page, it seemed to be broken
|
|
||
| - Store all images in the `Images/` subdirectory of a given notebook | ||
| - **Use SVG format** for diagrams when possible (scalable, editable) | ||
| - **Include source files**: We use [Excalidraw](https://excalidraw.com/) for diagrams. Include `.excalidraw` files alongside exported images for future maintenance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these requirements or "nice-to-have"s for the images and figures?
No description provided.