Skip to content

Conversation

@gevtushenko
Copy link
Contributor

No description provided.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Contributor

👋 Thank you for your contribution!

This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI.

@maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI.

@github-actions
Copy link
Contributor

⚠️ Unsigned Commits Detected

This pull request contains 1 unsigned commit(s):

  • 657cefe CUDA C++ Contriguting Guide

All commits must be signed before this PR can be merged. Please sign your commits by following these steps:

Option 1: SSH Key Signing (Recommended)

  1. Add your SSH key to GitHub (if not already done):

  2. Configure Git to use SSH signing:

    git config --global gpg.format ssh
    git config --global user.signingkey ~/.ssh/id_ed25519.pub  # or your key path
    git config --global commit.gpgsign true
  3. Re-sign your commits:

    git rebase -i HEAD~1 --exec "git commit --amend --no-edit -S"
    git push --force

Option 2: GPG Key Signing

  1. Generate a GPG key: GitHub Docs

  2. Add the GPG key to GitHub: GitHub Docs

  3. Configure Git to sign commits:

    git config --global user.signingkey YOUR_GPG_KEY_ID
    git config --global commit.gpgsign true
  4. Re-sign your commits (same as above):

    git rebase -i HEAD~1 --exec "git commit --amend --no-edit -S"
    git push --force

For more details, see GitHub's commit signature verification docs.


This comment will be updated when you push new commits.

@gevtushenko gevtushenko force-pushed the cpp-contributing-guide branch from 657cefe to a6af2d0 Compare January 12, 2026 04:22
Copy link

@smish-nvidia smish-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


You can find the full solution [here](Solutions/no-magic-execution-space-changes.cpp).
</details>
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these nested code fences seem to be formatted incorrectly, but I'm not sure how to escape the backticks

ach::where_am_I("CPU");
```

You can find the full solution [here](Solutions/no-magic-execution-space-changes.cpp).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I tried to follow this link from the markdown page, it seemed to be broken


- Store all images in the `Images/` subdirectory of a given notebook
- **Use SVG format** for diagrams when possible (scalable, editable)
- **Include source files**: We use [Excalidraw](https://excalidraw.com/) for diagrams. Include `.excalidraw` files alongside exported images for future maintenance.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these requirements or "nice-to-have"s for the images and figures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants