replace deprecated method grpc.DialContext in favour of grpc.NewClient#419
Open
tariq1890 wants to merge 1 commit intoNVIDIA:mainfrom
Open
replace deprecated method grpc.DialContext in favour of grpc.NewClient#419tariq1890 wants to merge 1 commit intoNVIDIA:mainfrom
tariq1890 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
de38605 to
1cae921
Compare
Collaborator
|
I ran unit tests, they fail with the error like: |
You might want to set the scheme as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc.DialContext is deprecated and calls
NewClientunder the hood. We also remove theWithBlockcall as the godoc ofNewClientsays that it is disregarded.