(helm chart) Make priorityClassName optional#538
Open
jyoungs wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
Signed-off-by: Jeff Youngs <jyoungs@bluenightmare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart currently always sets priorityClassName on the DaemonSet by using an inline default-- and not actually accepting the value as input (which seems like a problem even if you do want to require it).
Keeping the same default, I'm allowing priorityClassName to be omitted, which simplifies the process of deploying this in a non-standard namespace.
This is basically a copy of #438 , but I squashed and signed (per CONTRIBUTING.md).