new privileges for sandbox-device-plugin #2078
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatchopra
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
tariq1890
reviewed
Jan 28, 2026
| resources: | ||
| - jobs | ||
| verbs: | ||
| - create |
Contributor
There was a problem hiding this comment.
Do you need all of these permissions? I prefer starting with a minimal list. It seems that create, get, watch and delete would suffice here, yes?
Contributor
Author
There was a problem hiding this comment.
We can skip update I think. I always assumed watch requires list/get.
Fixed.
rajatchopra
force-pushed
the
gfd_in_sandbox_dp
branch
from
0535b48 to
ae11c8b
Compare
…vileges and info Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
rajatchopra
force-pushed
the
gfd_in_sandbox_dp
branch
from
ae11c8b to
0bbce4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sandbox-device-plugin will launch the GFD job within the sandbox env, so we need new privileges for it to do so
Changes:
GFD launch PR in sandbox-device-plugin: NVIDIA/sandbox-device-plugin#30
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manual testing on cluster