Skip to content

new privileges for sandbox-device-plugin #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajatchopra wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −0
Open

new privileges for sandbox-device-plugin #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions assets/state-sandbox-device-plugin/0200_role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,13 @@ rules:
- use
resourceNames:
- privileged
- apiGroups:
- batch
resources:
- jobs
verbs:
- create
Copy link
Contributor

@tariq1890 tariq1890 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need all of these permissions? I prefer starting with a minimal list. It seems that create, get, watch and delete would suffice here, yes?

Copy link
Contributor Author

@rajatchopra rajatchopra Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip update I think. I always assumed watch requires list/get.
Fixed.

- get
- list
- watch
- delete
11 changes: 11 additions & 0 deletions assets/state-sandbox-device-plugin/0500_daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,17 @@ spec:
imagePullPolicy: IfNotPresent
name: nvidia-sandbox-device-plugin-ctr
command: ["nvidia-kubevirt-gpu-device-plugin"]
env:
- name: NODE_NAME
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: spec.nodeName
- name: POD_NAMESPACE
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
securityContext:
privileged: true
volumeMounts:
Expand Down
10 changes: 10 additions & 0 deletions deployments/gpu-operator/templates/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,13 @@ rules:
- watch
- create
- update
- apiGroups:
- batch
resources:
- jobs
verbs:
- get
- list
- watch
- create
- delete