[dcgm-exporter] Add configure externalTrafficPolicy and nodePort for dcgmExporter service#1516
Draft
Alja9 wants to merge 3 commits intoNVIDIA:mainfrom
Draft
[dcgm-exporter] Add configure externalTrafficPolicy and nodePort for dcgmExporter service#1516Alja9 wants to merge 3 commits intoNVIDIA:mainfrom
Alja9 wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
…service Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Alja9
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Author
|
I have raised PR to dcgm exporter too : NVIDIA/dcgm-exporter#518 |
Alja9
changed the title
Contributor
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
rahulait
removed
the
lifecycle/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the dcgmExporter service supports configuring types, in my case I use a different cluster as a monitoring center so I need NodePort type and I can't use IP pod or original source IP for scraping, but
externalTrafficPolicy: Clusterwould really help in that case.But this will also help users if they need
externalTrafficPolicy: Localsuch as cases where only specific users need node local routing or to preserve the original IP. Reference : https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip