Add debug-level log option for ctk-installer #1551
Conversation
Signed-off-by: Jactor Sue <jactor_sue@live.com>
|
|
||
| var availableRuntimes = map[string]struct{}{"docker": {}, "crio": {}, "containerd": {}} | ||
| var defaultLowLevelRuntimes = []string{"runc", "crun"} | ||
| var ( |
There was a problem hiding this comment.
If you're going to make these changes please make them in a separate commit.
There was a problem hiding this comment.
Nothing changed here, auto-formated by the gofumpt formatter.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
I have made a proposal for using log-verbosity instead as well as some other changes that better align with some things that I've been considering recently.
Please feel free to squash / clean up as required.
| Usage: "enable debug-level log", | ||
| Destination: &options.debug, | ||
| Sources: cli.EnvVars("TOOLKIT_DEBUG"), | ||
| }, |
There was a problem hiding this comment.
One thing that we have been considering is switching to an explicit verbosity-based approach for this component so as to prepare for a switch to klog at some point. Could we changes this to:
| }, | |
| &cli.IntFlag{ | |
| Name: "log-versbosity", | |
| Aliases: []string{"v"}, | |
| Destination: &options.logVerbosity, | |
| Sources: cli.EnvVars("LOG_VERBOSITY"), | |
| }, |
There was a problem hiding this comment.
So you want to change logger from logrus to klog for whole toolkit stack or only for installer?
There was a problem hiding this comment.
The idea would be to move to something like logr.Logger internally, and then use klog in the installer and logrus for the CLI components. This may be longer term though, so a simpler change may be to ensure that the installer can have debug logging enabled as per your original change.
Deprecating the --debug flag, or mapping it to a well-defined log-verbosity at some point in the future would also be possible.
There was a problem hiding this comment.
(feel free to rebase and drop my commit so that I can review this).
2 participants
Enable debug-level log for nvidia-ctk-installer cmd by
--debugor-d.